search

eHealthAfrica / data-models-deprecated

Validation for standard data models
Apache License 2.0
4 stars 8 forks source link

add `dispatcherNotification` to the FollowUp schema #82

Closed danse closed 8 years ago

danse commented 8 years ago

See https://github.com/eHealthAfrica/sense-dispatch/issues/18

danse commented 8 years ago

So since this pull request was pending for more than one month, i push forced and lost the changes ... because of conflicts i thought that it was some change to the data model that somebody else did in the meantime ... :(

It does not matter now since the dispatcher was developed and never used, but in general this is bad, please review pull requests in a reasonable amount of time or notify when you are not able to make it.

Anyway, now it is about a different thing and i think that it will be better if @emig reviews it this time

danse commented 8 years ago

great catch, fixing that test showed me also an error in the schema. thanks @emig!