Coding styleguide and linting for Sass/CSS

eHealthAfrica / eHealthAfrica.github.io

The GHI eHealth Africa website

http://eHealthAfrica.github.io

4 stars 3 forks source link

Coding styleguide and linting for Sass/CSS #21

Open FrancescoK opened 9 years ago

FrancescoK commented 9 years ago

Suggestion:

Use Sass in every project
Adoption of the Sass guidelines by Hugo Giraudel (http://sass-guidelin.es/#too-long-didnt-read)
Add grunt-scss-lint to Gruntfiles throughout and use the suggested ruleset
Defer discussion of naming conventions and structure (e.g. OOCSS/BEM/etc.) to separate frontend/design topic
Add best practices about inclusion of Bootstrap, the theme or similar vendor libraries

tthew commented 9 years ago

:+1:

ally commented 9 years ago

:+1: :facepunch:

FrancescoK commented 9 years ago

grunt-scss-lint has a Ruby dependency :-/

tthew commented 9 years ago

This might help: sass-lint (needs to be evaluated)

FrancescoK commented 9 years ago

Evaluation: https://github.com/sasstools/sass-lint/blob/master/lib/sass-lint.js

tthew commented 9 years ago

haha omg.

tthew commented 9 years ago

@ally @adamvert @FrancescoK.

So we had some conversations around this; BEM seems to be the favoured model. Do you think we could move forward on this? Hugo's guidelines + BEM for new work?

FrancescoK commented 9 years ago

Yes, there seems to be a consensus around BEM. Personally I have always been reluctant because BEM is kinda ugly and seems overkill considering the relatively low complexity of our designs, but that’s not really a rational argument. Imho, let’s go forward with BEM. How to call things within BEM will be the more interesting discussion but hey :)