navbar becomes misaligned using different branding/fonts

[tlvince]

If the navbar does not contain an image in navbar-header > navbar-brand, it becomes misaligned:

This also occurs when $font-size-base is changed, as in the case of direct-delivery (https://github.com/eHealthAfrica/ehealth-bootstrap/pull/4):

[bnvk]

@tlvince in the NutSurv Mobile app this should be solved by adding an icon in the navbar. The icon for NutSurv is:

In the Direct Delivery app, why is the $font-size-base changed?

[tlvince]

$font-size-base is changed per user feedback; the app is used primarily outdoors on a tablet and the default size was found to be too small.

[tlvince]

Re nutsurv, agreed, adding an image will resolve this, but we've stringent requirements and there may be a reason the home icon is used. Will followup.

[FrancescoK]

The $font-size-base was changed for the same reason in Sense ID (BiometricRegistration), btw.

[bnvk]

@FrancescoK are you aware of what reason that is?

[FrancescoK]

Just as Tom said, on tablets it was just really tiny, several people complained about it. Bumped it to 16 or 17px iirc.

[bnvk]

@FrancescoK @tlvince OK, this really should be a non-problem with using my icons, as they're 24px high, which is why I had to auto center the App Name text, which is what is now screwed up. I made it bigger on purpose for this reason!

[tlvince]

So you're saying the issue will be resolved iff we use the app icons, regardless of $font-size-base?

[cristinasantamarina]

The home page is made as per Robert's spec and it is one of the pages for which we have a sign off. I am hesitant to make changes in the version of the app we will deploy.

[RobertJohnston]

Sorry, I made this crystal clear in the specifications and on the phone with Cristina that the home page should follow the specifications. So there is no sign off on the home page.

If this cannot be corrected before the delivery date, it will need to be changed after.

Thanks

On Mon, May 11, 2015 at 4:50 PM, Cristina Santamarina < notifications@github.com> wrote:

The home page is made as per Robert's spec and it is one of the pages for which we have a sign off. I am hesitant to make changes in the version of the app we will deploy.

— Reply to this email directly or view it on GitHub https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-100932848 .

[cristinasantamarina]

Robert you said the home page was good to go in the call we had in which we went through the apk and the ux doc. This to me is a sign off. We just need to make sure the image looks ok on the tablet. Other than thay what other changes are needed otherwise? On 11 May 2015 17:09, "Robert Johnston" notifications@github.com wrote:

Sorry, I made this crystal clear in the specifications and on the phone with Cristina that the home page should follow the specifications. So there is no sign off on the home page.

If this cannot be corrected before the delivery date, it will need to be changed after.

Thanks

On Mon, May 11, 2015 at 4:50 PM, Cristina Santamarina < notifications@github.com> wrote:

The home page is made as per Robert's spec and it is one of the pages for which we have a sign off. I am hesitant to make changes in the version of the app we will deploy.

— Reply to this email directly or view it on GitHub < https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-100932848

.

— Reply to this email directly or view it on GitHub https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-100938788 .

[RobertJohnston]

Hey Cristina,

When we discussed the home page about 2 months ago, we agreed that alerts would not go on the home page. I updated the specs document - sent to you and archived on google docs.

When we discussed on the phone, I brought up again that this issue had not been corrected. You mentioned that it would require hiring someone to do more work and would likely not happen before the delivery date. I make it clear that the dashboard including the home page should follow the specs even if that could not be completed before the delivery date.

Thanks

On Tue, May 12, 2015 at 7:03 AM, Cristina Santamarina < notifications@github.com> wrote:

Robert you said the home page was good to go in the call we had in which we went through the apk and the ux doc. This to me is a sign off. We just need to make sure the image looks ok on the tablet. Other than thay what other changes are needed otherwise?

On 11 May 2015 17:09, "Robert Johnston" notifications@github.com wrote:

Sorry, I made this crystal clear in the specifications and on the phone with Cristina that the home page should follow the specifications. So there is no sign off on the home page.

If this cannot be corrected before the delivery date, it will need to be changed after.

Thanks

On Mon, May 11, 2015 at 4:50 PM, Cristina Santamarina < notifications@github.com> wrote:

The home page is made as per Robert's spec and it is one of the pages for which we have a sign off. I am hesitant to make changes in the version of the app we will deploy.

— Reply to this email directly or view it on GitHub <

https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-100932848

.

— Reply to this email directly or view it on GitHub < https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-100938788

.

— Reply to this email directly or view it on GitHub https://github.com/eHealthAfrica/ehealth-bootstrap/issues/16#issuecomment-101133903 .

[jjal]

Hi all this repo is for the parent ehealth bootstrap theme and should not include changes or discussions for individual projects, which can override the bits they need to. Sounds like a separate parent bootstrap-mobile might be warranted too fwiw.