eLvErDe / yiimp-blocks-found-to-discord

Poll a Yiim pool block found result page and post a message to Discord chat room
BSD 3-Clause "New" or "Revised" License
1 stars 17 forks source link

Possible improvement #3

Open mtompkins opened 6 years ago

mtompkins commented 6 years ago

Perhaps wait a little while to understand if the block is an orphan and then post to discord? I'm not sure if it is something interesting but may be a nice touch to manage payment expectations.

eLvErDe commented 6 years ago

Can you explain a bit more the workflow (regarding block status) you have in mind ?

mtompkins commented 6 years ago

Sure, so right now when a block is found it is posted to the results page and your script properly scrapes it and announces it to Discord. Some blocks, as you know, are orphans (worthless). An example is Verge (XVG) which has about a 20%+ orphan rate at this time.

I would likely give the user one of a couple configs settings -

  1. Post all blocks as it currently does
  2. Post all blocks and announce when the block state is either immature (do price lookup) or orphan (do nothing) when known
  3. Post only immature blocks
eLvErDe commented 6 years ago

Btw, you might be interested in a second project I started:

https://github.com/eLvErDe/generate-cryptocoin-wallet-deb-package

It builds proper Debian/Ubuntu packages for various coins, with complete systemd integration, logrotate etc.... I also made available the resulting packages directly on a Debian repository: http://packages.le-vert.net/cryptocoin/

And if you want, you may request additional coin, I'll do.

mtompkins commented 6 years ago

Thanks - I use Arch so I don't deb. When I did, I fell in love with fpm. But interesting project, good luck with it!