eManPrague / frui.ts

Pragmatic MVVM frontend framework
MIT License
14 stars 5 forks source link

View component with useLifecycle doesn't run activate when VM being changed #49

Closed kopecmi8 closed 2 years ago

kopecmi8 commented 2 years ago

Due to refactor inside View component between versions 0.15.0 and 0.16.0 error occur when you try to update.

Consider for following code:

function renderViewModel(viewModel: any) {
  ReactDOM.render(<View vm={viewModel} useLifecycle />, document.getElementById("root"));
}

When you changes viewModel via prop at 0.15.0 activate callback run always. Now in 0.16.0 (and higher) activation callback run only when componentDidMount and doesn't run when VM being changed.

gius commented 2 years ago

Merged