search

eManPrague / frui.ts

Pragmatic MVVM frontend framework
MIT License
14 stars 5 forks source link

Navigation adapter cause error when user use back button and then want to navigate to same page. #9

Closed kopecmi8 closed 4 years ago

kopecmi8 commented 4 years ago

When user use back button and than want to go to same screen where has been, this condition https://github.com/eManPrague/frui.ts/blob/08450c1a3c3183a5b49459c0fb1ee696198f7fe0/packages/screens/src/navigation/urlNavigationAdapter.ts#L33 prevents to propage URL to the navigation bar. Problem is at onUrlChange method (https://github.com/eManPrague/frui.ts/blob/develop/packages/screens/src/navigation/urlNavigationAdapter.ts#L41) because it doesnt change the lastUrl....

kopecmi8 commented 4 years ago

I try to fix it at https://github.com/eManPrague/frui.ts/pull/10

gius commented 4 years ago

Thank you for the report! Please check the latest version v0.15.0-beta.5, it should be fixed there.