eMetaboHUB / MS-CleanR

25 stars 8 forks source link

Error in Negative mode #2

Closed ykim7263 closed 3 years ago

ykim7263 commented 3 years ago

Hi,

I have tried running MS-Clean R with my MS Dial data. I have both positive and negative datasets and I am trying to use them separately Everything went well with the positive mode data set. But the error popped up whenever i tried to use the negative data set. The error is described below.

Warning: Error in $<-.data.frame: replacement has 0 rows, data has 30997 [No stack trace available]

guikool commented 3 years ago

Please check the previously closed issue most of the errors come from no MS/MS data available in one of the scan mode (here probably negative) If you try to merge pos and neg mode, be careful to have exactly the same samples number in the same order in MS-Dial in case, send me the output files of MSdial on the email of the MScleanR corresponding author. Best regards G.

ykim7263 commented 3 years ago

Normalized_1_20212151651_pos.txt https://drive.google.com/file/d/1IBB6OI_ZUKsD6S1k35Sx7sL_oIKXYQbH/view?usp=drive_web Normalized_0_20212142141_neg.txt https://drive.google.com/file/d/1APvfw8sn-tPA9FPHDqF_0TqmCsrUWgkH/view?usp=drive_web Hi all,

I have checked my data and it contains MS2 scan on both polarities (Acquired by data dependent acquisition method) For your better understanding, I have attached aligned result files from both polarities. Just FYI, I really appreciate you for developing this software.

Best regards Kim

On Tue, Feb 16, 2021 at 12:07 PM guikool notifications@github.com wrote:

Please check the previously closed issue most of the errors come from no MS/MS data available in one of the scan mode (here probably negative) If you try to merge pos and neg mode, be careful to have exactly the same samples number in the same order in MS-Dial in case, send me the output files of MSdial on the email of the MScleanR corresponding author. Best regards G.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eMetaboHUB/MS-CleanR/issues/2#issuecomment-779979151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMSQ7M3JGPR2BWGFXHXEGSTS7KQ35ANCNFSM4XVUFDQQ .

guikool commented 3 years ago

Dear Kim According to the size of .txt files, I think R cannot handle this data, its too big...

To my mind you need to increase the baseline treshold in MSdial (minimum peak height), its a critical parameter as noticed in our tutorial.

If you use an orbitrap, test it between 1e6 to 5e6, for TOFMS you can try between 5000 and 10 000.

For complex samples, a feature number between 500 and 2000 is usual (for the height file after MSdial processing), if you exceed this number, you may reconsider your MSdial parameters.

Best

G.

ykim7263 commented 3 years ago

Hi,

I have modified the MSDIAL parameter, but it still shows the same error. It does work well with positive mode, even though it has a higher file size.

Best regard, Kim

ykim7263 commented 3 years ago

Just want to let you know I solve the problem with the negative mode error, so you can close the error. I have done two things, first I downgraded the vroom. Also, I overwrote the negative data (Height and normalized) onto the txt file generated from the positive mode.