search

eMoflon / emoflon-core

Core components of eMoflon
Other
5 stars 1 forks source link

Vis: Inherited attributes are visualised #108

Open anthonyanjorin opened 6 years ago

anthonyanjorin commented 6 years ago

Not sure how to deal with this. Right now all attributes of an EClass are visualised both inherited and non-inherited attributes. I don't think users expect to see inherited attributes (as this is also not the usual case in OO languages). We could of course also make this configurable.

anthonyanjorin commented 6 years ago

What do you think @eTralse ?

brandtjo commented 6 years ago

As a developer inspecting a class diagram, I wouldn't want inherited attributes to be displayed in a sub-class. On the other hand, there is no way now to identify inherited attributes in the parent class either, if the inherited attributes are not visualized in sub-classes. To solve this problem, one could use the proper modifier icons (i.e. for protected), which are already given in PlantUML.

For the implementation I would recommend to extend the ClassDiagram class to store an EClass to EAttribute mapping (or likewise implementation), to state which EAttributes are to be visualized for which EClass, thus reducing control-flow logic in the PlantUML generator. The determination of the EAttributes could then be realized in the Metamodel visualiser?

anthonyanjorin commented 5 years ago

Any progress on this issue? Have you been able to reproduce? Can you suggest a solution?