eMoflon / emoflon-core

Core components of eMoflon
Other
5 stars 1 forks source link

"Fixes" `MANIFEST.MF` newline/comma bug #141

Closed maxkratz closed 1 year ago

maxkratz commented 1 year ago

Before merging this PR, the manifest mechanism in emoflon-core produced invalid MANIFEST.MF files in some of the test cases.

Example:

...
Require-Bundle: org.emoflon.ibex.common,org.emoflon.ibex.gt,org.emoflon.ibex.
 ,patternmodel,org.emoflon.ibex.gt.democles,org.emoflon.ibex.gt.hipe
...

This PR "fixes" this behavior because each entry will be represented in its own line. However, there is the possibility that this causes an invalid MANIFEST.MF file if the complete value of one entry exceeds the 72 bytes per line limit, e.g., org.emoflon.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa. IMO, this is more desirable compared to the previous implementation that broke multiple (existing) files repeatedly.

Tested with: