search

eMoflon / emoflon-neo

A Neo4j-based implementation of eMoflon
Eclipse Public License 2.0
6 stars 2 forks source link

[Vis] In ored/anded constraints, variables are not shared... #123

Closed anthonyanjorin closed 5 years ago

anthonyanjorin commented 5 years ago

... but the visualisation suggests this (see GameOver in FruitGardenLanguage):

image

The correct visualisation should not connect garden:FruitGarden in the different patterns. Note that this is only the case for constraints connected by && and ||. In other cases the variables are shared and should be indicated in the visualisation.

maxischm commented 5 years ago

So, when visualizing constraints these connections should never be made but only when visualizing patterns/rules? Or did i miss a case in which the links must be visualized in constraints?

anthonyanjorin commented 5 years ago

Hmm... for if/else the variables are shared (and should be visualised as connected if of the same name).

In all other cases (for constraints), variables are not shared.

Right @hijan94 ?

hijan94 commented 5 years ago

Yes, that's right. In constraints shared variables can exist in if/else constraints only.