search

eMoflon / emoflon-neo

A Neo4j-based implementation of eMoflon
Eclipse Public License 2.0
6 stars 2 forks source link

Attribute Expression in flattened Rule uses Collection of un-flattened Rule for IndexOf(rel) calculation #188

Closed hijan94 closed 5 years ago

anthonyanjorin commented 5 years ago

@maxischm I have marked the test classes in our runtime workspace with //FIXME [Max] so you can easily find them in the tasks view. At the moment these tests fail with the message that a certain variable is missing... this is because the index used to generate the variable is wrong (as the wrong collection from the unflattened rule is being used).

maxischm commented 5 years ago

Ok, so I think I fixed it, but I can't test it because Java cannot find the function result.isEmpty() in the NeoController. I get a compilation error when I try to run the tests. Am i missing any plug-ins or do I have to use a specific Java version for it to work?

anthonyanjorin commented 5 years ago

Yes - that’s really weird. Use !isPresent() instead of isEmpty().

maxischm commented 5 years ago

Ok, the tests are green when I run them. A pull request with the fix is created.