eMoflon / emoflon-neo

A Neo4j-based implementation of eMoflon
Eclipse Public License 2.0
6 stars 2 forks source link

[Vis] Stackoverflow in visualisation #192

Closed anthonyanjorin closed 5 years ago

anthonyanjorin commented 5 years ago

In GameOfLife/Error.msl this causes a stack overflow in the visualisation:

pattern aLiveCell {
    cell:Cell {
        .alive : true
    }
} when forbid aLiveCell
maxischm commented 5 years ago

Ok, I think this is because the pattern has itself as condition and when copying, the Stackoverflow occurs. But, does it make sense to have a pattern as its own condition?

EDIT: I just saw that this is detected by the validator and an error is shown. I think we only have to stop the visualisation from trying to flatten this pattern then.

anthonyanjorin commented 5 years ago

Exactly - it doesn’t make sense at all. But a stackoverflow is pretty nasty (eclipse breaks down). The vis should just catch this and not try to visualise it.