[GEN] Transfer src and try NACs basically unchanged to generated GEN triple rules

eMoflon / emoflon-neo

A Neo4j-based implementation of eMoflon

Eclipse Public License 2.0

6 stars 2 forks source link

[GEN] Transfer src and try NACs basically unchanged to generated GEN triple rules #208

Closed anthonyanjorin closed 5 years ago

anthonyanjorin commented 5 years ago

See FacebookToInstagram for an example

Please do not implement this handling for any other ops (we need to discuss a bit how to handle NACs in all cases -- GEN is clear though).

LegionaryCohort commented 5 years ago

NACs are now being handled for GEN. Parameters in NACs are still to be done, currently they are simply directly copied over, should they exist (which I'm guessing will just break things, if that happens).

For the existing examples that use NACs, they are being compiled and added to the GEN rules.

anthonyanjorin commented 5 years ago

Can we close this now? @LegionaryCohort

LegionaryCohort commented 5 years ago

Yep, my bad, this is done