search

eMoflon / emoflon-neo

A Neo4j-based implementation of eMoflon
Eclipse Public License 2.0
6 stars 2 forks source link

Visualising multiple src/trg NACs in triple rules #224

Closed anthonyanjorin closed 4 years ago

anthonyanjorin commented 5 years ago

The following rule (HandleIntraNetworkFollowers : FacebookToInstagramGrammar) is not visualised as expected:

image

anthonyanjorin commented 5 years ago

@maxischm I'm suffering a bit due to this bug :(

Could you give me a pointer how to fix it if you do not have the time in the near future to do it yourself?

Thanks!

maxischm commented 5 years ago

Sorry I forgot about the issue and had some troubles with getting the workspace running again with all the new dependencies etc.

The problem is that the pattern is not correctly flattened before visualizing the connection. If you want to fix this yourself you just have to change line 974 in the DiagramTextProvider to flatten the pattern c before iterating over its nodes. (Otherwise I can also take a look at the other Issue and hopefully push both fixes this weekend.)

«FOR nb : EMSLFlattener.flatten(c.pattern).nodeBlocks» I tried this just now and the connections were drawn.

Am I missing something else that is wrong in the vis or was this all?

anthonyanjorin commented 5 years ago

Hi - sorry about the workspace... master should be stable now and both PSFs up-to-date. If not just ping me and I'll fix any problems.

This weekend would be absolutely ok -- thanks (at the moment there are only these two open vis issues)!