eMoflon / emoflon-tool

Source code of eMoflon::TIE-SDM
https://emoflon.org
Other
3 stars 2 forks source link

Latest version of eMoflon not backward compatible with existing TGG projects #230

Closed anthonyanjorin closed 7 years ago

anthonyanjorin commented 7 years ago

The latest version of eMoflon suddenly expects the xtext files to be at a different location than before (instead of src/org/moflon/tgg/mosl now src//org/moflon/tgg/mosl).

This breaks all existing TGG projects (I wonder how any single test is running).

anthonyanjorin commented 7 years ago

Found this in the changelog:

Old specifications remain compatible: The MOSL-TGG builder searches for any file named Schema.tgg in the /src folder

Doesn't work though.

anthonyanjorin commented 7 years ago

If I may say so this is also a very ugly change: (1) it violates normal Java package naming conventions, (2) renaming the project becomes quite problematic (refactoring in Eclipse won't help)

anthonyanjorin commented 7 years ago

Lastly, it is inconsistent as our attribute condition file AttributeCondDefLib still at its old position (right?).

RolandKluge commented 7 years ago

Old specifications remain compatible: The MOSL-TGG builder searches for any file named Schema.tgg in the /src folder

Yes, this was may plan, originally, but I failed to fully reverse engineer the way in which TGG schema and rules are loaded. @Arikae Maybe we should invest a little more effort to support any location for Schema.tgg files? Maybe we find a safe way to identify the "root" .tgg file that contains the schema definition.

anthonyanjorin commented 7 years ago

btw. I relocated my Schema.tgg file and it still didn't work. So basically all .tgg files in the project have to be relocated (strangely apart from the attribute condition library file).

RolandKluge commented 7 years ago

@Arikae Could you check that?

Arikae commented 7 years ago

Yup, I'll try to fix it

anthonyanjorin commented 7 years ago

Hi guys,

We've sent in a TTC proposal and this would mess up the installation instructions.

Please fix ASAP :)

erhanleblebici commented 7 years ago

fixed. As from now, there is no naming conventions for the tgg files and their packages. The only assumption is that all tgg files are in your src folder.