search

ePSIC-DLS / particlespy

Package for analysing particles in electron microscopy data sets.
GNU General Public License v3.0
19 stars 9 forks source link

Create boundary_analysis.py #52

Open YichiWang opened 4 years ago

YichiWang commented 4 years ago

This is a standalone script to perform particle boundary analysis such as boundary curvature and find boundary pixels in clockwise sequence.

Tom I am not sure how do you want to integrate this into ParticleSpy. One of your opened issue you mentioned could make particlespy to allow plug-in additions. This script can also be implemented to scikit-image in the future I think.

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into master will decrease coverage by 12.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
- Coverage   81.48%   69.39%   -12.09%     
===========================================
  Files          13       14        +1     
  Lines         821      964      +143     
===========================================
  Hits          669      669               
- Misses        152      295      +143
Impacted Files Coverage Δ
ParticleSpy/boundary_analysis.py 0.00% <0.00%> (ø)
TomSlater commented 4 years ago

I think this would be good to leave as a utility function that can be run on individual particles. i.e. it isn't run when doing ParticleAnalysis. It would be good to have a function that could be run on one Particle and one that could be run on a Particle_list.

What do you think the output for a user should be? Maybe a min, max and average curvature to be added to particle properties? Plus the option to plot the curvature of particles(s) when running the analysis?

YichiWang commented 4 years ago

I think this would be good to leave as a utility function that can be run on individual particles. i.e. it isn't run when doing ParticleAnalysis. It would be good to have a function that could be run on one Particle and one that could be run on a Particle_list.

What do you think the output for a user should be? Maybe a min, max and average curvature to be added to particle properties? Plus the option to plot the curvature of particles(s) when running the analysis?

Yes I agree to all above you suggested.