search

ePSIC-DLS / particlespy

Package for analysing particles in electron microscopy data sets.
GNU General Public License v3.0
19 stars 9 forks source link

Niblack and Sauvola #54

Closed CameronGBell closed 3 years ago

CameronGBell commented 3 years ago

13 Adds Niblack and Sauvola segmentation methods into SegUI.

Alters local threshold method to convert process_param["local_size"] into odd numbers for threshold_local

Fixed crashes when running ParticleAnalysis if loaded images are unitless

TomSlater commented 3 years ago

This is great, nice work.

As a note for the future, it would be good to separate different changes in to different pull requests (no matter how small). i.e. one bug fix goes in to one pull request. This way it's easier to track each change when building a new version.

As an exercise you could also write a test for either Niblack or Sauvola thresholding. If you look in the tests directory you'll find unit tests that are run every time there is a pull request. Are you happy to add a new test to test Niblack thresholding? It just needs to run the Niblack thresholding and test the output.

Also, it would be good to add the two new methods to the documentation. They should be added to the segmentation.rst file under Parameter Picking for Automated Segmentation point number 3. This documentation gets automatically built whenever a pull request is merged in to the release branch.