ePSIC-DLS / particlespy

Package for analysing particles in electron microscopy data sets.
GNU General Public License v3.0
19 stars 9 forks source link

New clustering methods #59

Closed CameronGBell closed 3 years ago

CameronGBell commented 3 years ago

Adds clustering methods for individual and series of images, using a number of filter kernels selectable using the list of dictionaries parameters

codecov[bot] commented 3 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.08%. The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   84.62%   84.70%   +0.08%     
==========================================
  Files          13       13              
  Lines         852      922      +70     
==========================================
+ Hits          721      781      +60     
- Misses        131      141      +10     
Impacted Files Coverage Δ
ParticleSpy/tests/test_particle_clustering.py 100.00% <ø> (ø)
ParticleSpy/ParticleAnalysis.py 91.03% <83.60%> (ø)
ParticleSpy/api.py 86.66% <100.00%> (ø)
...eSpy/ParticleSpy/tests/test_particle_clustering.py
...IC-DLS/ParticleSpy/ParticleSpy/ParticleAnalysis.py
.../ParticleSpy/ParticleSpy/tests/test_particle_io.py
...articleSpy/ParticleSpy/tests/generate_test_data.py
...ePSIC-DLS/ParticleSpy/ParticleSpy/particle_save.py
...uild/ePSIC-DLS/ParticleSpy/ParticleSpy/__init__.py
...ePSIC-DLS/ParticleSpy/ParticleSpy/particle_load.py
... and 19 more
CameronGBell commented 3 years ago

I'll probably add some more tests before merging, for each of the new functions I've added

CameronGBell commented 3 years ago

I'll add some test for the 2 new functions before the merge, to increase the code coverage

TomSlater commented 3 years ago

Looks good in general. It shouldn't be difficult to add in a mask for conversion to supervised learning too (i.e. when you've drawn on the image).

The parameter input is maybe a little difficult to change, but probably isn't an issue.

Once you add tests and documentation I'll test it out properly.

TomSlater commented 3 years ago

Is there anything in this PR that isn't in #60 ? I can't see anything but I just though I'd check. If not, I'll just check and merge #60 .