search

ePSIC-DLS / particlespy

Package for analysing particles in electron microscopy data sets.
GNU General Public License v3.0
19 stars 9 forks source link

Inconsistency in case of 'parameters' folder #69

Closed jlaehne closed 3 years ago

jlaehne commented 3 years ago

On linux, when I install from pip, the folder parameters has a lower case name, which results in failure of the code. Here in the repo it is upper case, but references to it are mixed, e.g.: https://github.com/ePSIC-DLS/ParticleSpy/blob/5225e331dd512639c9bb4a1b69bffeef3f881af4/ParticleSpy/ParticleAnalysis.py#L356 https://github.com/ePSIC-DLS/ParticleSpy/blob/5225e331dd512639c9bb4a1b69bffeef3f881af4/ParticleSpy/SegUI.py#L363

I think it would be preferable to have lower case parameters in the folder name and in any reference to this folder to avoid failures.

TomSlater commented 3 years ago

Thanks for pointing this out. I'm planning to switch everything to lower case only and will try to do this asap to solve this issue. Aiming for the next release.

jlaehne commented 3 years ago

Cool, I just fixed it locally for the meantime ;-)