search

ePSIC-DLS / particlespy

Package for analysing particles in electron microscopy data sets.
GNU General Public License v3.0
19 stars 9 forks source link

pyqt as optional dependency #70

Open ericpre opened 3 years ago

ericpre commented 3 years ago

qt is a one of the largest dependencies (100 Mo) and can't be used remotely (cloud or cluster). Making this dependency optional would allow to use smaller docker image, etc.

TomSlater commented 3 years ago

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

ericpre commented 3 years ago

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

TomSlater commented 3 years ago

This would make sense. I might make it so that the default is to include pyqt, but have the option to not include it for docker images etc.

Is it possible with pip?

I'm not sure it is, based on this thread. I could just strip out pyqt as a dependency and include its installation in the standard installation instructions.

TomSlater commented 3 years ago

Maybe it would make most sense to just have pyqt as an optional dependency but use this in the standard instructions.

ericpre commented 3 years ago

Yes, this is usually how it is done.

On a similar topic, it may be worth considering using qtpy, to allow using pyside.