search

ePages-de / restdocs-api-spec

Adds API specification support to Spring REST Docs
MIT License
391 stars 103 forks source link

feat: apply `@Min` `@Max` constraints to NumberSchema #199

Closed iwaltgen closed 2 years ago

iwaltgen commented 2 years ago

Apply @Min,@Max and @Size constraints to NumberSchema

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.09%) to 92.946% when pulling ec71534de594d183efef458bea2b7372390b9106 on iwaltgen:feat-constraint-size-string into 27db748dd39fee2b9c165db180074fea3ccd8ecd on ePages-de:master.

jmewes commented 2 years ago

Please add the newly supported constraints to the documentation in the README file:

https://github.com/ePages-de/restdocs-api-spec#documenting-bean-validation-constraints

iwaltgen commented 2 years ago

Hello @jmewes,

I'm still working on my English. Please correct the awkward explanation.

Thank you in advance.

jmewes commented 2 years ago

Hello @iwaltgen ,

Thanks for your contribution!

We are not native English speakers either ;)

jmewes commented 2 years ago

We can create a new release after processing the PR which you just created.

jmewes commented 2 years ago

@iwaltgen ,

I'll create a new release with this change since I am not familiar with the code affected by the other PR.