@WireMockTest usually requires @DirtiesContext

[otrosien]

Due to the fact that the wiremock test execution listener adds a new property source that is unknown when we started the application context from a different test. So we need to restart the application context, in order to access our wiremock.port property. We need to find a better approach.

[otrosien]

look at ContextCustomizer from spring framework 4.3

[poznachowski]

Hi, You may find this helpful: https://github.com/neoteric-eu/neo-starters/tree/development/neo-starter-test/src/main/java/eu/neoteric/starter/test/wiremock We did something similar but using MockBean.

The problem I'm struggling with right now, how to force FeignClients to use Wiremock without Ribbon, which translates to using FeignClient with url parameter (it will fallback to normal Feign). Wondering if you ever thought about it?

[otrosien]

AFAIR we had this in place. If you use @FeignClient(url=".. some spel expression") you can make that spel expression resolve to the WireMock location.

[otrosien]

@poznachowski thanks for the link BTW. Important part here is that we don't let wiremock choose a random port, but we probe a free port and save this in a spring property, which later gets assigned as fixed port to wiremock. This property is the sauce for further configuration of your FeignClient or other services.

[poznachowski]

np :) I think that I don't see the difference. In my solution I also look up for a free port, starts Wiremock with that, and sets that all Feign clients connects to it. Does that behaviour differs from yours? I don't have to provide specific Feign clients to point to Wiremock server, as all of them base on the AbstractLoadBalancer class.

With using spel expression, that would require providing in every test with Wiremock Feign client name and I wanted to avoid that and come up with generic solution for all Feign clients available.

[otrosien]

hm. You might be overengineering things. From my point of view the test should know which feign client it needs to wire to wiremock. Not all FeignClients on the classpath should - only the one you're interested in testing.

@UlfS @jensfischerhh correct me if I'm wrong, but what we're doing is something along the lines of this:

SomeFeignClient.class

@FeignClient(url="${someFeignClient.baseUri}")
interface SomeFeignClient {}

.. and application-test.yml

someFeignClient.baseUri: http://localhost:${wiremock.port}/

[otrosien]

.. haven't touched spring code for a while, so i feel a bit rusty... ;-)

[ulfsauer0815]

@otrosien Yup, that's what we're doing, but I think we are using the @SpingBootTest annotation to set the property, otherwise wiremock.port wouldn't be available yet at the time the application-test.yml is processed.

[otrosien]

@UlfS actually both should work. In client/src/test/resources/application-test.properties there's a working example. Maybe we should add a test case with @SpringBootTest annotation.

[zjedi]

all our wiremock tests ended up being ignored, because they somehow pollute spring context and plain DirtiesContext is not enough. The only thing that helps is applying DirtiesContext before every test class (even those that have nothing to do with wiremock). Just not worth the trouble.