search

ePages-de / restdocs-wiremock

Spring REST Docs WireMock Integration
Apache License 2.0
75 stars 27 forks source link

Spring Boot 2.0 compatibility #62

Closed otrosien closed 6 years ago

otrosien commented 6 years ago

Epic for work on Spring Boot 2.0 compatibility.

Izakey commented 6 years ago

@otrosien Please could you kindly help out with #61 ?

mduesterhoeft commented 6 years ago

@otrosien Just gave it a try and it seems that restdocs-wiremock works fine with spring-boot 2.0.0.RELEASE (which is using spring-restdocs 2.0.0.RELEASE).

snicoll commented 6 years ago

Relates to https://github.com/spring-projects/spring-boot/issues/13510

mduesterhoeft commented 6 years ago

@snicoll @otrosien it looks like the starter also works in spring boot 2.0 I could run the examples with spring boot 2.0

See https://github.com/ePages-de/restdocs-wiremock/tree/spring-boot-2.0

mduesterhoeft commented 6 years ago

The question that remains is if we want to move this project to spring boot 2.0 already. @otrosien what do you think?

otrosien commented 6 years ago

👍 ... Is epages ready for 2.0?

snicoll commented 6 years ago

I am a bit confused. Do you have a CI or something that makes sure it works with the latest 2.x release?

mduesterhoeft commented 6 years ago

@snicoll I just created a branch - updated the sample application to use spring boot 2 and ran the tests. That worked fine without touching the actual code of the starter or the spring-restdocs integration.

Travis builds every branch - and also the build for this particular branch is green - https://travis-ci.org/ePages-de/restdocs-wiremock/builds/395420454

I think we will shortly upgrade the project to spring boot 2 completely.

But if you need/expect sth else please let me know.