search

eProsima / Fast-DDS-Gen

Fast-DDS IDL code generator tool. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
77 stars 59 forks source link

[20335] Fix TypeObjectPair API #296

Closed JLBuenoLopez closed 3 months ago

JLBuenoLopez commented 5 months ago

eProsima/Fast-DDS#4368 modifies TypeObjectPair API. This PR updates the TypeObjectSupport tests template accordingly.

JLBuenoLopez commented 5 months ago

Manual CI: SUCCESS

JLBuenoLopez commented 4 months ago

Manual CI after rebase

JLBuenoLopez commented 3 months ago

I will ask for a manual CI once the corresponding PR in Fast DDS is merged

JLBuenoLopez commented 3 months ago

Perhaps implementing two accessor functions in TypeObjectPair to replace complete_type_object.complete() and minimal_type_object.minimal() would enhance readability. Otherwise, I believe it's good. Waiting for that CI

I do not agree. The type already provides the accessors that are being used. It would be like a wrapper, but this is not done for any other substructure within the TypeObject. So I am for keeping it as it is for consistency reasons. As for readability, it clarifies which substructure is being accessed too.

JLBuenoLopez commented 3 months ago

Manual CI: SUCCESS