Fix inheritance with aliases [20621]

eProsima / Fast-DDS-Gen

Fast-DDS IDL code generator tool. Looking for commercial support? Contact info@eprosima.com

Apache License 2.0

77 stars 59 forks source link

Fix inheritance with aliases [20621] #316

Closed richiware closed 4 months ago

richiware commented 4 months ago

This PR fixes an inheritance from an alias is not generated.

Depends on:

eprosima/idl-parser#125

adriancampo commented 4 months ago

Is it possible to detect this bug in some regression tests?

richiware commented 4 months ago

Is it possible to detect this bug in some regression tests?

I believe not, because the test is already there, but the generated code is valid. I found the bug when writtind DynamicTypes with the inheritance.idl and found several structures are not inheriting.

adriancampo commented 4 months ago

I thought that was going to be the case. LGTM with green CI then.

adriancampo commented 4 months ago

CI: https://github.com/eProsima/Fast-DDS-Gen/actions/runs/8249687965