eProsima / Fast-DDS-Gen

Fast-DDS IDL code generator tool. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
82 stars 62 forks source link

is_plain_xcdrv1_impl() and is_plain_xcdrv2_impl() are identical in generated code #390

Closed zoeeer closed 2 months ago

zoeeer commented 2 months ago

When a type is declared with @final extensibility, the generated code has two versions for is_plain() method, but they seem identical.

see: https://github.com/eProsima/Fast-DDS/commit/4c9f1d6ff2bd6ef4ab79327809c0e74f3db74238#r146264299

image

The type is defined as such:

@extensibility(FINAL)
struct DeliveryMechanisms
{
    unsigned long index;
    char message[32];
};
Mario-DL commented 2 months ago

Hi @zoeeer,

Yes, the same output will be produced for plain and final for serialization mechanisms except if using unsigned long long or unsigned double. Feeling free to close this as it is not an issue.

zoeeer commented 2 months ago

oh, thanks for the explanation.