search

eProsima / Fast-DDS-statistics-backend

eProsima Fast DDS Statistics Backend is a C++ library that provides collection and procession the statistics measurements reported by Fast DDS Statistics Module. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
17 stars 9 forks source link

[14468][14469] Use correct format locator in `init_monitor` #157

Closed JLBuenoLopez closed 2 years ago

JLBuenoLopez commented 2 years ago

This PR fixes the documentation because the locators need to have a different format for init_monitor to succeed (this method uses Locator operator >> from Fast DDS public utils API).

It also includes some more tests checking that when the locator does not have the expected format, init_monitor throws. One test have been disabled because it was not testing what was intended. Fixing the test has shown a bug that should be fixed in Fast DDS (deserializing locator port, there is no check to ensure that it is not a negative number).

codecov[bot] commented 2 years ago

Codecov Report

Merging #157 (8f665a5) into main (59e750b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files          31       31           
  Lines        4328     4328           
  Branches     2319     2319           
=======================================
  Hits         2499     2499           
  Misses         60       60           
  Partials     1769     1769

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59e750b...8f665a5. Read the comment docs.