Open jparisu opened 1 year ago
Base: 58.42% // Head: 58.42% // No change to project coverage :thumbsup:
Coverage data is based on head (
d7bd7bf
) compared to base (74f5197
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@EduPonz I think I don't have enough knowledge about bash scripting to review this one ...
@jparisu Please rebase this one
I have rebased the PR while looking at it. I think we ought to have a discussion about this; right now, it's a draft as it is far from being ready to be incorporated in CI and merged. The pain points I see with the current for merging as a test are:
Another possibility would be to add the script as a resource from which users can benefit, but I'm really attracted to the idea of having this kind of stress tests.
Another possibility would be to add the script as a resource from which users can benefit, but I'm really attracted to the idea of having this kind of stress tests.
This test was never meant to be added in the CI. This was intended to be a manual test to have a partial idea of what is the memory usage of an execution. In order to automatize it and have a failing criteria I think it could not be done as results highly depend on the architecture, OS and state of the machine where tests are running. I think it would be better to have it as a helper script rather than an actual test (does Fast DDS have memory usage automatized tests with failing criteria?).
PD: I personally think we have bigger problems that having a stress test.
This is an image of the results obtained by running this test:
I completely agree. I'd leave this as a draft for now and we'll see in the future
@jparisu which is the status of this Draft? Does it make sense to try to merge it? I think we should change the status and assign a milestone so the discussion is had at some point.
Merge after:
175
178
172
174
177
176