search

eProsima / Fast-DDS-statistics-backend

eProsima Fast DDS Statistics Backend is a C++ library that provides collection and procession the statistics measurements reported by Fast DDS Statistics Module. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
17 stars 9 forks source link

[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY #195

Open Mario-DL opened 1 year ago

Mario-DL commented 1 year ago

In order to avoid a compilation issue with clang #184 a refactor of EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY. This implies an API Break.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (73a70d3) 58.46% compared to head (98d7de9) 58.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #195 +/- ## ======================================= Coverage 58.46% 58.46% ======================================= Files 38 38 Lines 4485 4485 Branches 2383 2383 ======================================= Hits 2622 2622 Misses 55 55 Partials 1808 1808 ``` | [Impacted Files](https://codecov.io/gh/eProsima/Fast-DDS-statistics-backend/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eProsima) | Coverage Δ | | |---|---|---| | [src/cpp/database/database.cpp](https://codecov.io/gh/eProsima/Fast-DDS-statistics-backend/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eProsima#diff-c3JjL2NwcC9kYXRhYmFzZS9kYXRhYmFzZS5jcHA=) | `52.62% <100.00%> (ø)` | | | [src/cpp/database/entities.hpp](https://codecov.io/gh/eProsima/Fast-DDS-statistics-backend/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eProsima#diff-c3JjL2NwcC9kYXRhYmFzZS9lbnRpdGllcy5ocHA=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eProsima). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eProsima)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

srmainwaring commented 1 year ago

Also checked on macOS Ventura 13.4, Xcode 14.3.1.

Issue is legacy BSD extensions to the C standard defined in MacOSX.sdk/usr/include/math.h.

If Fast-DDS-monitor is similarly patched the monitor builds and runs on macOS (good to have!).

Could this change please be merged, it's a pre-requisite for: