[20815] Only apply content filter to ALIVE changes

EduPonz commented 1 month ago

Description

Backport of #4835 to 2.x

This PR fixes a bug that caused the content filter to also be applied to unregister and disposed samples. Since in those messages the only fields populated (if any) are the ones annotated with @key, the unregister and dispose samples did not pass the filter (in general) and thus were being discarded. This caused several issues:

When writing to more than 10 instances with default Qos (keep last 1, max_instances 10), only the first 10 samples were been received.
In best effort, when setting the history depth and max instances appropriately, all samples were received, but calls to unregister or dispose followed by a write were triggering sample_lost events, as the received sequence numbers were not consecutive (because of the filtering out of the unregister/dispose).

This PR fixes these issues by only querying for sample relevance when the CacheChange kind is ALIVE.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[x] Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
[x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
[x] Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
[x] Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

EduPonz commented 1 month ago

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify[bot] commented 1 month ago

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

* [#4902 [20815] Only apply content filter to ALIVE changes (backport #4876)](https://github.com/eProsima/Fast-DDS/pull/4902) has been created for branch `2.13.x` but encountered conflicts * [#4903 [20815] Only apply content filter to ALIVE changes (backport #4876)](https://github.com/eProsima/Fast-DDS/pull/4903) has been created for branch `2.10.x` but encountered conflicts * [#4904 [20815] Only apply content filter to ALIVE changes (backport #4876)](https://github.com/eProsima/Fast-DDS/pull/4904) has been created for branch `2.6.x` but encountered conflicts

EduPonz commented 1 month ago

@richiprosima please test this

EduPonz commented 1 month ago

@richiprosima please test discovery-server

EduPonz commented 1 month ago

@richiprosima please test discovery-server

EduPonz commented 1 month ago

@richiprosima please test discovery-server

eProsima / Fast-DDS