[21121] IPayloadPool refactor

cferreiragonz commented 4 months ago

Description

This PR adds two main changes:

It moves payload_owner_ from CacheChange_t to SerializedPayload_t
Refactors IPayloadPool class and all derived classes to only manage SerializedPayload_t, instead of CacheChange_t
get_payload() methods refactor
SerializedPayload_t copies are forbidden

In this way, the payload_owner_ is no longer related to a cache change, but to the payload it refers.

Contributor Checklist

[X] Commit messages follow the project guidelines.
[X] The code follows the style guidelines of this project.
[X] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[X] Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
❌ Changes are API compatible.
[x] New feature has been added to the versions.md file (if applicable).
[X] New feature has been documented/Current behavior is correctly described in the documentation.
- Related documentation PR: https://github.com/eProsima/Fast-DDS-docs/pull/800
- N/A Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

cferreiragonz commented 4 months ago

Since the payload_owner_ now belongs to the SerializedPayload_t, I believe the get_payload() method receiving a source SerializedPayload_t&, an IPayloadPool* and a destination SerializedPayload_t& could be simplified removing the IPayloadPool* parameter, as it is already contained in the source payload. I let the reviewer the decision of keeping it or not.