eProsima / Fast-DDS

The most complete DDS - Proven: Plenty of success cases. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
2.06k stars 738 forks source link

[21144] Fix Doxygen errors for Doxygen versions prior to 1.8.19 #4896

Closed EduPonz closed 1 month ago

EduPonz commented 1 month ago

Description

This PR fixes some Doxygen errors when generating the API reference with Doxygen versions prior to 1.8.19, as it is the case of Fast DDS docs RTD page, which is generated in Ubuntu 20.04 and therefore with Doxygen 1.8.17. Although Doxygen documentation documents the dir attribute of the param directive to be one of [in], [out], and [in,out], doxygen/doxygen#7881 introduced, among other things, the possibility to set the dir attribute to [in out], which #4746 introduced in several places.

Mind that in the dev machines this "mistake" went undetected because of the use of Ubuntu 22.04 (Doxygen 1.9.1). Also, even though an error when generating the Doxygen documentation makes Fast DDS docs build to fail when building it through CMake, the RTD generation is done within conf.py directly, and the return code of the subprocess is not checked, which makes the RTD documentation to finish the build but then show an error on the API reference as follows.

image

This has been addressed in:

The doxygen documentation is updated in:

Contributor Checklist

Reviewer Checklist