eProsima / Fast-DDS

The most complete DDS - Proven: Plenty of success cases. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
2.06k stars 738 forks source link

[21136] Bugfix: Revert XML Flow controller names to `const char*` #4911

Closed Mario-DL closed 1 month ago

Mario-DL commented 1 month ago

Description

PR #4893 introduced an ABI break changing the flow controller descriptor names to std::string. This PR reverts that change and handles the flow controller names in a collection within XMLParser. It also defines a clear() method intended to clean the collection upon XMLProfileManager destruction.

Note I introduced a mutex but I dont think it is needed 100% since the XMLParser configuration may be something sequential, but I introduced it anyways.

Important A cherry pick of this PR should be merged in the following backports

Contributor Checklist

Reviewer Checklist

JesusPoderoso commented 1 month ago

@richiprosima please test this

JesusPoderoso commented 1 month ago

@richiprosima please test this

EduPonz commented 1 month ago

@Mario-DL please remember to cherry-pick this onto the other backports

Mario-DL commented 1 month ago

Cherry picks added 👍🏻