[21095] Example refactor: Discovery Server

Mario-DL commented 1 month ago

Description

This PR refactors the DiscoveryServerExample with the current new example format. It also adds proper tests for the examples testing automation.

Contributor Checklist

[X] Commit messages follow the project guidelines.
[X] The code follows the style guidelines of this project.
NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
NO Any new/modified methods have been properly documented using Doxygen.
NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
NO Changes are API compatible.
[X] New feature has been added to the versions.md file (if applicable).
NO New feature has been documented/Current behavior is correctly described in the documentation.
NO Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

Mario-DL commented 1 month ago

Discovery server tests passed although configuration timed out. @elianalf I guess we can start reviewing and later on I will rebase on top of the example splitting PR

Mario-DL commented 1 month ago

What a great refactor!

Only one thing, I have tried to run the Server with transport UDPV6 and TCPV6 and it fails creating the participant, in particular because "Discovery Server wasn't able to allocate the specified listening port."

Ty ! Its true, good catch, it was the fact that if the listening address is not specified in the server we need to change the default one to ::1

MiguelCompany commented 1 month ago

I think it would be better to rebase this on top of #4716, since we are changing the behavior of Discovery Server

elianalf commented 2 weeks ago

The only thing that needs to be changed is the guards in all the .hpp files, following the style in this PR, we can skip CI after the commit.

elianalf commented 2 weeks ago

LGTM! CI passed here

eProsima / Fast-DDS