[21165] Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API

EduPonz commented 1 month ago

Description

This PR changes the values of the MatchingFailureMask so they can be directly used through the std::bitset API. Before this PR, the following code:

EDP::MatchingFailureMask mask;
mask.set(EDP::MatchingFailureMask::different_typeinfo);

resulted in a C++ exception as follows:

"bitset::set: __position (which is 16) >= _Nb (which is 16)"

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
[x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
[x] Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
[x] Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

EduPonz commented 1 month ago

@richiprosima please test discovery-server

EduPonz commented 1 month ago

@richiprosima please test_3 discovery-server

EduPonz commented 1 month ago

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

mergify[bot] commented 1 month ago

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

* [#4925 [21165] Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API (backport #4922)](https://github.com/eProsima/Fast-DDS/pull/4925) has been created for branch `2.14.x` but encountered conflicts * [#4926 [21165] Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API (backport #4922)](https://github.com/eProsima/Fast-DDS/pull/4926) has been created for branch `2.13.x` but encountered conflicts * [#4927 [21165] Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API (backport #4922)](https://github.com/eProsima/Fast-DDS/pull/4927) has been created for branch `2.10.x` but encountered conflicts * [#4928 [21165] Correctly initialize `MatchingFailureMask` constants to be used with the `std::bitset` API (backport #4922)](https://github.com/eProsima/Fast-DDS/pull/4928) has been created for branch `2.6.x` but encountered conflicts

eProsima / Fast-DDS