eProsima / Fast-DDS

The most complete DDS - Proven: Plenty of success cases. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
2.16k stars 765 forks source link

Following "Linux installation from sources", missing pip dependency for colcon build #4933

Closed gstangel closed 3 months ago

gstangel commented 3 months ago

Is there an already existing issue for this?

TLDR: Need to add pip3 install -U colcon-gradle to install instructions,

Expected behavior

Expected Behavior - able to follow install steps without errors

mkdir ~/Fast-DDS cd ~/Fast-DDS wget https://raw.githubusercontent.com/eProsima/Fast-DDS/master/fastdds.repos mkdir src vcs import src < fastdds.repos colcon build

Current behavior

Colcon throws error about missing package

mkdir ~/Fast-DDS cd ~/Fast-DDS wget https://raw.githubusercontent.com/eProsima/Fast-DDS/master/fastdds.repos mkdir src vcs import src < fastdds.repos colcon build [1.885s] WARNING:colcon.colcon_core.verb:No task extension to 'build' a 'gradle' package

Steps to reproduce

Follow steps in https://fast-dds.docs.eprosima.com/en/latest/installation/sources/sources_linux.html

Fast DDS version/commit

v2.14.1

Platform/Architecture

Other. Please specify in Additional context section.

Transport layer

Default configuration, UDPv4 & SHM

Additional context

The fix was to run pip3 install -U colcon-gradle

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

Mario-DL commented 3 months ago

Hi @gstangel, Thanks for using Fast DDS ! While it is true that fastddsgen is also listed in the fastrtps.repos, hence discovered by colcon during compilation, it is meant to be an independent tool (in fact, we may consider removing it from the .repos file). Anyways, we will internally consider your suggestion.

Mario-DL commented 3 months ago

I am feeling free to close this issue as the above PR fixes the issue

gstangel commented 3 months ago

I am feeling free to close this issue as the above PR fixes the issue

Thank you!