[21184] Refactor XML Parser to return DynamicTypeBuilder instead of DynamicType

elianalf commented 2 weeks ago

Description

This PR is a small refactor of the methods to get dynamic types from XML in order to return a DynamicTypeBuilder object instead of a DynamicType one. It also add a CLI flag to xtypes example to load types and profiles from an xml files.

Contributor Checklist

[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[x] Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
❌ Changes are API compatible.
[x] New feature has been added to the versions.md file (if applicable).
[x] New feature has been documented/Current behavior is correctly described in the documentation. Related documentation PR: eProsima/Fast-DDS-docs#818 -->
N/A Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

elianalf commented 1 week ago

* Also, I am getting a `AddressSanitizer:DEADLYSIGNAL` if I start the publisher with `--xml-type` (compiled with ASAN), we may need to investigate it further.

I have tried to reproduce the error, and it appears when the xml file is not uploaded through environment variable. Can you check if that is the case? I will expand the README to clarify that using the --xml-types option requires setting an environment variable with the path to the XML file you wish to use.

elianalf commented 6 days ago

Suggestions applied!

Leaving unresolved just a couple of conversations above that I think were not included

eProsima / Fast-DDS