eProsima / Fast-DDS

The most complete DDS - Proven: Plenty of success cases. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
2.16k stars 765 forks source link

[21245] Fix topic interference on `liveliness_changed` status #4988

Closed MiguelCompany closed 3 months ago

MiguelCompany commented 3 months ago

Description

PR #4822 (and its backports) introduced a regression that was not detected until we requested ROS 2 rolling to use branch 2.14.x here

This PR:

  1. Adds infrastructure to create Blackbox tests that simulate the behavior of ROS 2 node
  2. Adds a ROS2 black-box test trying to mimick the test that regressed
  3. Add a standard black-box regression test for the issue discovered
  4. Fixes the issue

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

Reviewer Checklist

MiguelCompany commented 3 months ago

@mergifyio backport 2.14.x

mergify[bot] commented 3 months ago

backport 2.14.x

🛑 Command backport 2.14.x cancelled because of a new backport command with different arguments

MiguelCompany commented 3 months ago

@mergifyio backport 2.14.x

mergify[bot] commented 3 months ago

backport 2.14.x

✅ Backports have been created

* [#5032 [21245] Fix topic interference on `liveliness_changed` status (backport #4988)](https://github.com/eProsima/Fast-DDS/pull/5032) has been created for branch `2.14.x` but encountered conflicts