In intraprocess there is a race in destruction since the LatencySubsriber deletes its participant and then, when the LatencyPublisher deletes their entites it tries to access the EDP builtins on the LatencySubscriber which are deleted.
This PR lets the user endpoints be destroyed while guaranteeing that both are alive before deleting the participants.
In addition, proposes a refactor for using a BaseReader instead of a RTPSReader for the local_reader_ member of the readerproxy to save up a dynamic_cast when downcasting.
Contributor Checklist
[X] Commit messages follow the project guidelines.
[X] The code follows the style guidelines of this project.
NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[X] Any new/modified methods have been properly documented using Doxygen.
NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
❌ Changes are API compatible.
NO New feature has been added to the versions.md file (if applicable).
NO New feature has been documented/Current behavior is correctly described in the documentation.
NO Applicable backports have been included in the description.
Reviewer Checklist
[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.
Description
Some of the
Latency tests
failed in mac from time to time, in particular, the intraprocess ones. Analysis revealed the following backtrace:In
intraprocess
there is a race in destruction since theLatencySubsriber
deletes its participant and then, when theLatencyPublisher
deletes their entites it tries to access theEDP
builtins on theLatencySubscriber
which are deleted.This PR lets the user endpoints be destroyed while guaranteeing that both are alive before deleting the participants.
In addition, proposes a refactor for using a
BaseReader
instead of aRTPSReader
for thelocal_reader_
member of thereaderproxy
to save up adynamic_cast
when downcasting.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist