[21314] Improve resilience against clock adjustments

ma30002000 commented 3 months ago

Description

When investigating a system undergoing larger system clock adjustments, I noticed that in some places, std::chrono::system_clock and std::chrono::high_resolution_clock are used for handling timeouts and status check intervals. However, std::chrono::system_clock is definitely not steady, and std::chrono::high_resolution_clock is not steady quite often (see cppreference).

When undergoing clock adjustments (manually or due to clock server synchronization), timeouts and status checks might no longer be triggered when relying on timestamps based on std::chrono::system_clock.

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
[x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
[x] Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
[x] Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.

ma30002000 commented 2 months ago

Is there anything I need to to in order to get CI results?

JesusPoderoso commented 2 months ago

Hi @ma30002000, thanks for your contribution. We will look at it in the following days and order CI. Thanks for your patience!

MiguelCompany commented 1 month ago

Manual CIs:

MiguelCompany commented 1 month ago

@Mergifyio backport 2.14.x 2.10.x

mergify[bot] commented 1 month ago

backport 2.14.x 2.10.x

✅ Backports have been created

* [#5189 [21314] Improve resilience against clock adjustments (backport #5018)](https://github.com/eProsima/Fast-DDS/pull/5189) has been created for branch `2.14.x` but encountered conflicts * [#5190 [21314] Improve resilience against clock adjustments (backport #5018)](https://github.com/eProsima/Fast-DDS/pull/5190) has been created for branch `2.10.x` but encountered conflicts

eProsima / Fast-DDS