We currently don't have support for key-only payloads bigger than the KEY_HASH length.
Receiving such kind of messages produces a segfault in DataReaderHistory.
This PR adds a regression test reproducing the issue, and fixes it by considering the incoming change as irrelevant.
It has been done this way so it is acknowledged in reliable topics, thus avoiding the offending data to be resent.
@Mergifyio backport 2.14.x 2.10.x
@Mergifyio backport 2.6.x
Contributor Checklist
[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
[x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
[x] Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
[x] Applicable backports have been included in the description.
Reviewer Checklist
[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.
This is an automatic backport of pull request #5262 done by Mergify.
Description
We currently don't have support for key-only payloads bigger than the KEY_HASH length. Receiving such kind of messages produces a segfault in DataReaderHistory.
This PR adds a regression test reproducing the issue, and fixes it by considering the incoming change as irrelevant. It has been done this way so it is acknowledged in reliable topics, thus avoiding the offending data to be resent.
@Mergifyio backport 2.14.x 2.10.x
@Mergifyio backport 2.6.x
Contributor Checklist
[x] Commit messages follow the project guidelines.
[x] The code follows the style guidelines of this project.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
[x] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
[x] Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
[x] Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5262 done by Mergify.