eProsima / Fast-DDS

The most complete DDS - Proven: Plenty of success cases. Looking for commercial support? Contact info@eprosima.com
https://eprosima.com
Apache License 2.0
2.16k stars 765 forks source link

[21751] Discard changes with big key-only payload and no key hash (backport #5262) #5274

Closed mergify[bot] closed 2 days ago

mergify[bot] commented 1 week ago

Description

We currently don't have support for key-only payloads bigger than the KEY_HASH length. Receiving such kind of messages produces a segfault in DataReaderHistory.

This PR adds a regression test reproducing the issue, and fixes it by considering the incoming change as irrelevant. It has been done this way so it is acknowledged in reliable topics, thus avoiding the offending data to be resent.

@Mergifyio backport 2.14.x 2.10.x

@Mergifyio backport 2.6.x

Contributor Checklist

Reviewer Checklist

JesusPoderoso commented 2 days ago

CI issues are unrelated to the PR content Ready to merge!