eProsima / Micro-XRCE-DDS-Agent

Micro XRCE-DDS Agent respository. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
102 stars 72 forks source link

Allow overriding the client's domain ID through reference #331

Closed iluetkeb closed 1 year ago

iluetkeb commented 1 year ago

As discussed on micro-ros/micro-ros-agent#182

The way this works is that if you set the domain-id to 255 on the client (an ID which is otherwise outside of the allowed range), it will be overridden by the value specified in the reference.

richiprosima commented 1 year ago

Build status:

richiprosima commented 1 year ago

Build status:

pablogs9 commented 1 year ago

@Acuadros95 please run a Micro XRCE-DDS tests using this contribution

Acuadros95 commented 1 year ago

@pablogs9 Tests running on https://github.com/eProsima/Micro-XRCE-DDS/pull/158

pablogs9 commented 1 year ago

Success here https://github.com/eProsima/Micro-XRCE-DDS/pull/158#issuecomment-1501665830, we can S&M into develop

pablogs9 commented 1 year ago

Please @iluetkeb rebase into develop

richiprosima commented 1 year ago

Build status:

pablogs9 commented 1 year ago

@Acuadros95 PTAL and S&M