eProsima / Micro-XRCE-DDS-Apps

Looking for commercial support? Contact info@eprosima.com
10 stars 5 forks source link

CAN utils #10

Closed vibnwis closed 4 years ago

vibnwis commented 4 years ago

I was wondering if anyone know the initialisation part of the canutils ? In the folder, I see it set/get the baudrate and various CAN mode, and Read/Write CAN frame functions. However, it has no initialisation, does anyone know? or is there a way to reach out to the code team mates?

pablogs9 commented 4 years ago

Closing since not related to to the Micro XRCE-DDS Apps.

The master branch of this repo is a Nuttx fork, this cantutils belong to Nuttx, not XRCE-DDS.

vibnwis commented 4 years ago

Hi Pablo, Agreed. Out of curiosity why the canutils is part of the Micro-XRCE-DDS-Apps? Don't get me wrong, this is anyway challenging your decision.

On Tue, 27 Oct 2020 at 19:39, Pablo Garrido notifications@github.com wrote:

Closing since not related to to the Micro XRCE-DDS Apps.

The master branch of this repo is a Nuttx fork, this cantutils belong to Nuttx, not XRCE-DDS.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eProsima/Micro-XRCE-DDS-Apps/issues/10#issuecomment-717021280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCYQVWMLISG545BKIOGYY3SMZTKDANCNFSM4TALSSIQ .

pablogs9 commented 4 years ago

Hello @vibnwis, I have just changed the main branch of this repo because the one where you are talking about is outdated.

Let me explain this movement:

Previously this repo is just a clone of Nuttx Apps with some minor modifications in order to build Micro XRCE-DDS for Nuttx. Here is where you can see the canutils folder, but as a part of the clone of the original repo.

Later, we split this repo into 3 different folders: FreeRTOS, Zephyr and Nuttx, providing a way to build XRCE-DDS Client for each of these RTOS. As you can see, the CAN support is RTOS and platform-dependent, and is not related to the Micro XRCE-DDS support.

vibnwis commented 4 years ago

Got it. Thank you for your thorough explanation.

On Tue, 27 Oct 2020 at 21:07, Pablo Garrido notifications@github.com wrote:

Hello @vibnwis https://github.com/vibnwis, I have just changed the main branch of this repo because the one where you are talking about is outdated.

Let me explain this movement:

Previously this repo is just a clone of Nuttx Apps https://github.com/apache/incubator-nuttx-apps with some minor modifications in order to build Micro XRCE-DDS for Nuttx. Here is where you can see the canutils folder, but as a part of the clone of the original repo.

Later, we split this repo into 3 different folders: FreeRTOS, Zephyr and Nuttx, providing a way to build XRCE-DDS Client for each of these RTOS. As you can see, the CAN support is RTOS and platform-dependent, and is not related to the Micro XRCE-DDS support.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eProsima/Micro-XRCE-DDS-Apps/issues/10#issuecomment-717063663, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCYQVQOT4PF4NVSKBKPOWLSMZ5TFANCNFSM4TALSSIQ .