search

eProsima / Micro-XRCE-DDS-Client

Micro XRCE-DDS Client repository. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
134 stars 83 forks source link

UXR_CONFIG_CAN_TRANSPORT_MTU is not in defined by CMake #369

Closed yashi closed 1 year ago

yashi commented 1 year ago

UXR_CONFIG_CAN_TRANSPORT_MTU, which was introduced in 8c0a608cd84f60218a54a629ebd8e64cb2d99a4a, is not defined by CMakeLists.txt unlike other *_TRANSPORT_MTUs. Instead it is defined in and only in include/uxr/client/profile/transport/can/can_transport.h

https://github.com/eProsima/Micro-XRCE-DDS-Client/blob/master/include/uxr/client/profile/transport/can/can_transport.h#L32

Nothing critical. I just noticed it while reading the code.

pablogs9 commented 1 year ago

CAN-FD MTU is fixed by standard to 64B: https://en.wikipedia.org/wiki/CAN_FD.

This is why it is not configurable.

yashi commented 1 year ago

Thanks!

yashi commented 1 year ago

might be better to rename it to UXR_CAN_TRANSPORT_MTU instead.

pablogs9 commented 1 year ago

That would be nice for sure!

yashi commented 1 year ago

370 if you like it.