search

eProsima / Micro-XRCE-DDS-Client

Micro XRCE-DDS Client repository. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
130 stars 82 forks source link

transport/can: Rename UXR_CONFIG_CAN_TRANSPORT_MTU #371

Closed yashi closed 11 months ago

yashi commented 11 months ago

Because CAN-FD MTU is fixed, it's not configurable. UXR_CONFIG_CAN_TRANSPORT_MTU is a bit misleading. Thus, this commit rename it to UXR_CAN_TRANSPORT_MTU.

I've missed the target branch on #370. Hope it works this time.

pablogs9 commented 11 months ago

Sorry @yashi, it seems that our CI has some troubles with your remote branch, I have created this one: https://github.com/eProsima/Micro-XRCE-DDS-Client/pull/372

And CI is running there.

Your authorship is maintained in the commit, so, if you are ok with it, we can merge the new one and close this. Let me know.

yashi commented 11 months ago

no problem at all.

yashi commented 11 months ago

BTW, is it because I have my repo under a different name?

pablogs9 commented 11 months ago

Not sure... but the CI fails to fetch your branch somehow.