eProsima / Micro-XRCE-DDS-Gen

Micro XRCE-DDS IDL code generator tool. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
10 stars 13 forks source link

Add support for modules in examples #48

Closed pablogs9 closed 1 year ago

Ryanf55 commented 1 year ago

Thoughts on making the header guard longer? There may be multiple Time messages in different modules. https://google.github.io/styleguide/cppguide.html#The__define_Guard

Before:

#ifndef _Time_H_
#define _Time_H_

#ifdef __cplusplus
extern "C"
{
#endif

#include <stdint.h>
#include <stdbool.h>

typedef struct builtin_interfaces_msg_Time

After:

#ifndef _BuiltinInterfacesMsgTime_H_
#define _BuiltinInterfacesMsgTime_H_

#ifdef __cplusplus
extern "C"
{
#endif

#include <stdint.h>
#include <stdbool.h>

typedef struct builtin_interfaces_msg_Time
pablogs9 commented 1 year ago

No problem, could you open a PR?

Ryanf55 commented 1 year ago

Yes.