Closed pablogs9 closed 1 year ago
Thoughts on making the header guard longer? There may be multiple Time messages in different modules. https://google.github.io/styleguide/cppguide.html#The__define_Guard
Time
Before:
#ifndef _Time_H_ #define _Time_H_ #ifdef __cplusplus extern "C" { #endif #include <stdint.h> #include <stdbool.h> typedef struct builtin_interfaces_msg_Time
After:
#ifndef _BuiltinInterfacesMsgTime_H_ #define _BuiltinInterfacesMsgTime_H_ #ifdef __cplusplus extern "C" { #endif #include <stdint.h> #include <stdbool.h> typedef struct builtin_interfaces_msg_Time
No problem, could you open a PR?
Yes.
Thoughts on making the header guard longer? There may be multiple
Time
messages in different modules. https://google.github.io/styleguide/cppguide.html#The__define_GuardBefore:
After: