search

eProsima / Micro-XRCE-DDS

An XRCE DDS implementation. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
157 stars 17 forks source link

Wrong member order in ObjectInfo type #137

Open jseldent opened 2 years ago

jseldent commented 2 years ago

Micro-XRCE-DDS reverses the order of the activity and config members in ObjectInfo. According to the official dds_xrce_types.idl, it should be

    @extensibility(FINAL)
    struct ObjectInfo {
        @optional  ActivityInfoVariant  activity;
        @optional  ObjectVariant        config;
    };

But an actual INFO message looks like screenshot which has config first.

pablogs9 commented 2 years ago

Is the dissector also in the wrong order?

jseldent commented 2 years ago

Yes. That's how I discovered the bug, because I couldn't properly dissect the INFO message if I didn't swap the order.

pablogs9 commented 2 years ago

We will take this into account in next release