search

eProsima / Micro-XRCE-DDS

An XRCE DDS implementation. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
156 stars 17 forks source link

ASIO vs Boost::Asio #23

Closed iluetkeb closed 3 years ago

iluetkeb commented 5 years ago

ASIO from ckohlhoff is required for building, but it appears that it is the same as boost::asio, which is already present on most systems. Would it be possible to use boost::asio instead?

BorjaOuterelo commented 5 years ago

Hi @iluetkeb.

We are using ckohlhoff's as boost:asio introduced some dependencies. https://www.boost.org/doc/libs/1_41_0/doc/html/boost_asio/using.html

The commit that changed from boost to third-party asio was: https://github.com/eProsima/Fast-RTPS/commit/4666e34d0f04267e58ff4f13e1b0a356741a3b70

Ideally, they should be interchangeable if you satisfy boost::asio dependencies. The usage of asio in Micro XRCE-DDS Agent is under revision anyway.

iluetkeb commented 5 years ago

Hi,

okay, understood.

FWIW: In my book, having a few more dependencies is no big issue, as long as I can get them through the system package manager.

My main issue is that I would like to use the system fastrtps, not yours, to avoid compatibility issues. ASIO is the main stumbling block for that, but I'll manage.

Best Regards / Mit freundlichen Grüßen

-- Dr. Ingo Lütkebohle CR/AEX3

Tel. +49(711)811-12248 | Mobil +49-1525-8813417

► Take a look at Bosch Research: www.bosch.com/research

Von: Borja Outerelo notifications@github.com Gesendet: Dienstag, 15. Januar 2019 09:23:50 An: eProsima/Micro-XRCE-DDS Cc: Luetkebohle Ingo (CR/AEX3); Mention Betreff: Re: [eProsima/Micro-XRCE-DDS] ASIO vs Boost::Asio (#23)

Hi @iluetkebhttps://github.com/iluetkeb.

We are using ckohlhoff's as boost:asio introduced some dependencies. https://www.boost.org/doc/libs/1_41_0/doc/html/boost_asio/using.html

The commit that changed from boost to third-party asio was: eProsima/Fast-RTPS@4666e34https://github.com/eProsima/Fast-RTPS/commit/4666e34d0f04267e58ff4f13e1b0a356741a3b70

Ideally, they should be interchangeable if you satisfy boost::asio dependencies. The usage of asio in Micro XRCE-DDS Agent is under revision anyway.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/eProsima/Micro-XRCE-DDS/issues/23#issuecomment-454305187, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARpgg0QuuQzVMZYFBXsN2kPJtAFy0XEks5vDZAWgaJpZM4Z-Pbo.

BorjaOuterelo commented 5 years ago

My main issue is that I would like to use the system fastrtps, not yours, to avoid compatibility issues. ASIO is the main stumbling block for that, but I'll manage.

Should not be an issue if you have FastRTPS (A compatible version with the Micro XRCE-DDS Agent) and asio installed.

FastRTPS would use the system asio. Micro XRCE-DDS Agent would use the system FastRTPS and the system asio.

I can help you If you need help with this. I compiled FastRTPS and install FastRTPS 1.7.0 and then compile Micro XRCE-DDS Agent with no extra flags needed without issues.

iluetkeb commented 5 years ago

Well, with "system fastrtps", I meant the version that comes with ROS Crystal. I probably should have said "ROS fastrtps" ;-)

but let's resolve https://github.com/microROS/rmw-microxrcedds/issues/12 first, then we'll see what's really needed.