search

eProsima / code-style

0 stars 1 forks source link

uncrustify error #10

Open felixf4xu opened 5 months ago

felixf4xu commented 5 months ago

Hi,

When I created the PR (https://github.com/eProsima/Fast-CDR/pull/210) and I would like to run uncrustify like this:

    Fast-CDR>uncrustify -c ..\code-style\uncrustify.cfg -replace .\src\cpp\Cdr.cpp --no-backup

but I got several errors:

..\code-style\uncrustify.cfg:408: option 'sp_type_question' is deprecated; did you want to use 'sp_before_ptr_star' instead? ..\code-style\uncrustify.cfg:902: option 'sp_before_tr_emb_cmt' is deprecated; did you want to use 'sp_before_tr_cmt' instead? ..\code-style\uncrustify.cfg:905: option 'sp_num_before_tr_emb_cmt' is deprecated; did you want to use 'sp_num_before_tr_cmt' instead? Option: at ..\code-style\uncrustify.cfg:1055: Expected number , for 'indent_shift'; got 'false' ..\code-style\uncrustify.cfg:1121: option 'indent_sing_line_comments' is deprecated; did you want to use 'indent_single_line_comments_before' instead? Option: at ..\code-style\uncrustify.cfg:1202: Expected number , for 'indent_comma_paren'; got 'false' Option: at ..\code-style\uncrustify.cfg:1206: Expected number , for 'indent_bool_paren'; got 'false' ..\code-style\uncrustify.cfg:2041: option 'nl_func_var_def_blk' is deprecated; it has been replaced by 'nl_var_def_blk_end_func_top'. You can also use 'nl_var_def_blk_end' for additional functionality Option: at ..\code-style\uncrustify.cfg:2535: Expected unsigned number , for 'align_nl_cont'; got 'false' Option: at ..\code-style\uncrustify.cfg:2724: Expected unsigned number , for 'mod_full_brace_if_chain'; got 'false' ..\code-style\uncrustify.cfg:2889: option 'pp_space' is deprecated; it has been replaced by 'pp_space_after'. Option: at ..\code-style\uncrustify.cfg:2944: Expected number , for 'pp_indent_brace'; got 'true' Failed to load (-replace)

Some of them are warnings, but the one like this is error.

Option: at ..\code-style\uncrustify.cfg:1202: Expected number , for 'indent_comma_paren'; got 'false'

uncrustify --version:

Uncrustify-0.78.1_f

JesusPoderoso commented 5 months ago

Hi @felixf4xu, we are going to update the uncrustify version eventually, but it is not part of our short-term roadmap.