search

eProsima / foonathan_memory_vendor

foonathan/memory vendor package for Fast DDS. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
23 stars 47 forks source link

Prepare 1.0.0 #30

Closed nuclearsandwich closed 4 years ago

nuclearsandwich commented 4 years ago

There are no code changes since the 0.6.0 release. This version bump serves to commit to the "public API" such as it is for this vendor package and is part of the work to get packages in the ROS 2 core up to a 1.0-level commitment.

MiguelCompany commented 4 years ago

@nuclearsandwich Should we also change version stability section on the quality declaration?

Other than that, I'm fine with the changes.

nuclearsandwich commented 4 years ago

@nuclearsandwich Should we also change version stability

@brawner could use your advice here. Do we make the change post-hoc once we have a 1.0 or touch that file in this version bump commit?

brawner commented 4 years ago

It makes sense to me to update the Quality Declaration in this PR if possible.

nuclearsandwich commented 4 years ago

It makes sense to me to update the Quality Declaration in this PR if possible.

Done and rebased this on the latest master with other changes to the quality declaration.

nuclearsandwich commented 4 years ago

@MiguelCompany I would be grateful for your review after which I'll rebase-merge and tag the result as v1.0.0.

MiguelCompany commented 4 years ago

I would be grateful for your review

Done!

after which I'll rebase-merge and tag the result as v1.0.0.

Please go ahead!